-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: maintain task meta in singleTaskMetaMgr #34214
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1beef9389f69429d5537850b136bee547965dc3f |
/run-integration-br-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@buchuitoudegou: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5834c9f
|
/run-build |
1 similar comment
/run-build |
/run-all-tests |
/run-build |
/run-integration-br-test |
/hold Wait for the integration-br-test to pass. |
/run-mysql-test |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.3 in PR #34225 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.4 in PR #34226 |
TiDB MergeCI notify
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.0 in PR #34229 |
What problem does this PR solve?
Issue Number: close #34213
Problem Summary:
Lightning precheck doesn't check local disk resources and cluster available.
What is changed and how it works?
When
incremental-import
is set to false, Lightning doesn't create a metadata schema in downstream TiDB. Instead, it creates asingleTaskMetaMgr
to maintain task metadata. However,singleTaskMetaMgr
always returns true for task existence check.tidb/br/pkg/lightning/restore/meta_manager.go
Line 1088 in 9fc73ac
Precheck for local disk resources and cluster available are accidentally skipped. Because lightning thinks the check has been performed before.
tidb/br/pkg/lightning/restore/restore.go
Line 1923 in 9fc73ac
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.